DrupalDork.com was shut down on September 18, 2013. This is just a snapshot of the site as it appeared then.

Intro to Github Pull Requests

Submitted by Brock on Wed 25 Apr 2012, 8:43 pm

If your company is hosting code in Github, I sure hope you aren't committing directly to master. This quick screencast demonstrates how to use pull requests so that teammates can review code before it gets merged into the master branch.

Make sure you turn on HD so that the text is legible.

Category:

Comments

ericduran (not verified)

Thu 26 Apr 2012, 7:26 am

Great video. One great thing to note is that even after you delete the branch you were working on. The pull request and all it's history will still be available for you to look back on. I love this feature :)

Shane (not verified)

Fri 27 Apr 2012, 9:01 pm

Thanks for this video. I have used BZR and launchpad.net in the past but am in the middle of a transitioning to Github. A few quick questions on how you (and others) use Github to manage their Drupal projects.

Do you version control the entire project (including core Drupal), or do you just version control the site directory (or sites "all" directory on a single site install)?

One problem I had with BZR was that I often version control modules that I used on client websites. This way if I make a change to one of my modules, I can easily roll this out to all of my clients that use that module with a simple pull. If I then wanted to version control the entire site, I ran into issues. I know Git can work with this type of nesting, but my question is, do you know a better way? Just looking to streamline my process as much as possible.

Thanks again for the great video.

Brock

Sat 28 Apr 2012, 9:10 pm

This past week was my first at Lullabot, so I'm still learning how they typically do things there, but I've always included the full Drupal core and any contrib modules in the repo.

I've avoided git submodules because support is still iffy on some hosts, if you're deploying from the repo hosting service. IN particular, Beanstalk only supports the master branch of any submodules, and that's what we used at my last employer.

I'm sure there's a better way to handle it, but I haven't found it yet. However, I also haven't looked very hard, because I haven't had enough client sites to maintain at one time to make it worth spending the time to dig into it.

William Jamieson (not verified)

Wed 7 Nov 2012, 6:53 pm

Thanks Brock! Great tutorial. We're just starting to create and contribute to public projects so this was a great help :)

Add new comment